Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHIS2-18837: add headers and query params auth schemes to Route API #19804

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

cjmamo
Copy link
Contributor

@cjmamo cjmamo commented Jan 29, 2025

No description provided.

@cjmamo cjmamo requested review from abyot and a team January 29, 2025 11:30
@cjmamo cjmamo self-assigned this Jan 29, 2025
@cjmamo cjmamo changed the title feat(DHIS2-18837): backport #19763 DHIS2-18837: add headers and query params auth schemes to Route API Jan 29, 2025
@cjmamo
Copy link
Contributor Author

cjmamo commented Jan 29, 2025

@jbee do you know why this test keeps failing?

AppHubControllerTest.testListAppHub_ClientError:67->DhisMockMvcControllerTest.assertWebMessage:64->DhisMockMvcControllerTest.assertWebMessage:71 unexpected message ==> expected: <I/O error on GET request for "http://localhost/doesnotwork/apps": Connection refused (Connection refused); nested exception is java.net.ConnectException: Connection refused (Connection refused)> but was: <I/O error on GET request for "http://localhost/doesnotwork/apps": Connect to localhost:80 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused (Connection refused); nested exception is org.apache.http.conn.HttpHostConnectException: Connect to localhost:80 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused (Connection refused)>

@david-mackessy
Copy link
Contributor

david-mackessy commented Jan 30, 2025

@jbee do you know why this test keeps failing?

@cjmamo It says why it's failing in the error message. The expected error message is different than the actual error message.
Possibly due to a library/JDK change that makes the web call during the test.
I'd suggest that you make the assert more lenient so it will pass a string assertion.
The test is also not in current master, so maybe it has been removed completely, you can check into that.

@cjmamo
Copy link
Contributor Author

cjmamo commented Feb 3, 2025

It says why it's failing in the error message

Yeah, but why is this happening only to me? I'm seeing other PRs getting merged to the 2.40 branch.

Copy link

sonarqubecloud bot commented Feb 3, 2025

@cjmamo cjmamo merged commit d0d6058 into 2.40 Feb 3, 2025
15 checks passed
@cjmamo cjmamo deleted the DHIS2-18837-2.40 branch February 3, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants