Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove entities service dependency from relationship service [DHIS2-18883] #19832

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

enricocolasante
Copy link
Contributor

@enricocolasante enricocolasante commented Jan 31, 2025

Our goal is to have every entity service depending only on its child services and always consider relationships as leaves in the dependency tree.
First step is to remove the dependency on TrackedEntityService, EnrollmentService and EventService that was present in RelationshipOperationParamsMapper and create methods in RelationshipStore to retrieve a single entity of any type using Hibernate.

Next steps

  • Migrate and fix commented tests in RelationshipsExportControllerTest
  • Move relationship handling into RelationshipService (Remove all getRelationshiItems methods from entity service and centralize them in RelationshipService)
  • Pass field params to RelationshipService in order to only retrieve from the DB what is needed
  • Check how we should deal with deleted entities in RelationshipService

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
5 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@enricocolasante enricocolasante marked this pull request as ready for review January 31, 2025 14:53
@enricocolasante enricocolasante requested a review from a team as a code owner January 31, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant