chore: Remove entities service dependency from relationship service [DHIS2-18883] #19832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our goal is to have every entity service depending only on its child services and always consider relationships as leaves in the dependency tree.
First step is to remove the dependency on
TrackedEntityService
,EnrollmentService
andEventService
that was present inRelationshipOperationParamsMapper
and create methods inRelationshipStore
to retrieve a single entity of any type using Hibernate.Next steps
RelationshipsExportControllerTest
RelationshipService
(Remove allgetRelationshiItems
methods from entity service and centralize them inRelationshipService
)RelationshipService
in order to only retrieve from the DB what is neededdeleted
entities inRelationshipService