chore: Migrate all relationship controller tests [DHIS2-18883] #19874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricocolasante
requested review from
a team,
ameenhere,
muilpp,
teleivo and
zubaira
teleivo
approved these changes
Feb 7, 2025
| @Test | ||
| void getRelationshipsByTrackedEntityWithProgramOwners() { | ||
| @Test | ||
| void shouldGetRelationshipsByTrackedEntityWithAttributes() { |
There was a problem hiding this comment.
is there a test using the same request without tracker data view to show what influence it has?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing migrate and fix commented tests in
RelationshipsExportControllerTest.trackerDataViewis working as expected and all related tests are migrated and they are passing.Next steps
RelationshipStoreinterface.RelationshipServicein order to only retrieve from the DB what is needed.deletedentities inRelationshipService.