DHIS2-18568: hard-code response timeout to 30 seconds #19880
+86
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjmamo
changed the title
|
jbee
reviewed
Feb 8, 2025
Comment on lines
+267
to
+269
| Map<String, Object> route = new HashMap<>(); | ||
| route.put("name", "route-under-test"); | ||
| route.put("url", "http://localhost:" + mockServerContainer.getFirstMappedPort()); |
There was a problem hiding this comment.
You can do this with json-tree, have a look at Json.object
| @Autowired private RouteService service; | ||
|
|
||
| @Autowired private ObjectMapper jsonMapper; | ||
| private MockServerClient mockServerClient; |
There was a problem hiding this comment.
I assume you are mocking a service that the routing somehow wants to talk with but that doesn't get clear in any why from the code. Maybe find some names that don't tell me what it is on a technical level (I can see that in the class name) but what the instance is doing, what role it has.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.