fix: don't set hibernate auto-ddl DHIS2-18961 [2.40] #19882
Merged
+162
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
force-pushed
the
DHIS2-18961-2.40
branch
2 times, most recently
from
e00ba85 to
79e3dc9
Compare
teleivo
force-pushed
the
DHIS2-18961-2.40
branch
from
79e3dc9 to
421da9c
Compare
|
jbee
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #19871
its harder and harder to backport the changes from
#19856
#19870
as the configs are so different.
I cannot without a LOT of effort override the
HibernateConfigurationProvider. The easiest solution I've found is adding a constructor specifically for H2 tests that passes in the hibernate value of "update". The default constructor which is used everywhere else uses "validate".https://github.com/dhis2/dhis2-core/pull/19882/files#diff-daecdbfebb119b10e966c65ea0a410fb1d12ad88dee1586c8718e1588a1fb4f0R105-R120