Set target policy version instead of just minumum#53
Merged
Conversation
Should allow building the cpp component with modern cmakes while not requiring us to set policies individually to avoid warnings (...mostly)
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should allow building the cpp component with modern cmakes while not requiring us to set policies individually to avoid warnings (...mostly)
Removed the cmp0077 policy because this appeared to be set only for nholmon::json, but that project contains a conditional block that sets the policy to new if the policy version is higher than 3.13 anyway. We were already using that since the min version is 3.14
fixes #50
Somewhat related, I'm still getting the following warning because I'm using cmake3.30+:
I think fixing this would require bumping the minimum version to 3.28 and replacing our custom function with the new options added to FetchContent_Declare/FetchContent_MakeAvailable():