chore: 修改组件扩展运算符 #1696
Merged
chore: 修改组件扩展运算符 #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 19, 2024 11:44
hiyuki
reviewed
Dec 3, 2024
| ...styles | ||
| } | ||
| const originStyle = nodeInstance.props.current.style | ||
| const finalStyle = nodeInstance.instance.style |
There was a problem hiding this comment.
直接传递style就可以了，不需要读取props中的style
hiyuki
reviewed
Dec 3, 2024
| currentTarget: { | ||
| ...(event.currentTarget || {}), | ||
|
|
||
| const currentTarget = extendObject( |
There was a problem hiding this comment.
extendObject的设计需要对齐Object.assign，不要默认加入空对象，保障方法的灵活性
hiyuki
reviewed
Dec 3, 2024
| ...(event.currentTarget || {}), | ||
|
|
||
| const currentTarget = extendObject( | ||
| event.currentTarget || {}, |
There was a problem hiding this comment.
Object.assign接收undefined，不需要兜底空对象
hiyuki
reviewed
Dec 3, 2024
| } | ||
| const defaultViewStyle = extendObject( | ||
| styles.button, | ||
| isMiniSize ? styles.buttonMini : {}, |
hiyuki
reviewed
Dec 3, 2024
| @@ -46,7 +46,7 @@ export interface CheckboxProps extends Selection { | |||
| 'parent-height'?: number; | |||
| children?: ReactNode | |||
| bindtap?: (evt: NativeSyntheticEvent<TouchEvent> | unknown) => void | |||
| catchtap?: (evt: NativeSyntheticEvent<TouchEvent> | unknown) => void | |||
| _onChange?: (evt: NativeSyntheticEvent<TouchEvent> | unknown, { checked }: { checked: boolean }) => void | |||
hiyuki
reviewed
Dec 3, 2024
| }) | ||
| } | ||
| if (bindmessage) { | ||
| Object.assign(events, { |
Refactor rn components spread cr
hiyuki
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.