Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onUnhandledRejection 支持core-js promise polyfill #1822

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: onUnhandledRejection 支持core-js promise polyfill #1822

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
581523c
feat: onUnhandledRejection 支持core-js promise polyfill
Jan 17, 2025
31280e7
feat: onUnhandledRejection 支持core-js promise polyfill
Jan 17, 2025
dc25d11
feat: onUnhandledRejection 支持core-js promise polyfill
Jan 17, 2025
56fe10d
feat: onUnhandledRejection 支持core-js promise polyfill
Jan 17, 2025
36ec118
Merge branch 'master' into feat-polyfill-UnhandledRejection
hiyuki Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/core/src/platform/env/index.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,15 @@ function initGlobalErrorHandling () {
}
}

// 支持 core-js promise polyfill
const oldOnUnhandledRejection = global.onunhandledrejection
global.onunhandledrejection = function onunhandledrejection (event) {
// event = { promise, reason }
rejectionTrackingOptions.onUnhandled(null, event.reason)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把promise作为三个参数传过去，然后onUnhandled中做一下兼容处理

oldOnUnhandledRejection.apply(this, event)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这应该是call吧

}
if (global?.HermesInternal?.hasPromise?.()) {
global.HermesInternal?.enablePromiseRejectionTracker?.(rejectionTrackingOptions)
global.HermesInternal.enablePromiseRejectionTracker?.(rejectionTrackingOptions)
} else {
require('promise/setimmediate/rejection-tracking').enable(rejectionTrackingOptions)
}
Expand Down
Loading