fix: 更新单测

didi · Dec 31, 2024 · 35b174c · 35b174c
1 parent 5019523
commit 35b174c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/server/src/modules/survey/__test/survey.controller.spec.ts b/server/src/modules/survey/__test/survey.controller.spec.ts
@@ -138,6 +138,9 @@ describe('SurveyController', () => {
       const reqBody = {
         surveyId: surveyId.toString(),
         configData: {
+          dataConf: {
+            dataList: [{ question: 'Test Question' }],
+          },
           /* ... your config data here ... */
         },
         sessionId: 'mock-session-id',
@@ -159,6 +162,28 @@ describe('SurveyController', () => {
         controller.updateConf(reqBody, { user: {} }),
       ).rejects.toThrow(HttpException);
     });
+    it('should throw an error when missing question data', async () => {
+      const surveyId = new ObjectId();
+      const reqBody = {
+        surveyId: surveyId.toString(),
+        configData: {
+          dataConf: {
+            dataList: [], // Empty dataList
+          },
+        },
+        sessionId: 'mock-session-id',
+      };
+
+      try {
+        await controller.updateConf(reqBody, {
+          user: { username: 'testUser', _id: 'testUserId' },
+          surveyMeta: { _id: surveyId },
+        });
+      } catch (error) {
+        expect(error).toBeInstanceOf(HttpException);
+        expect(error.message).toBe('请添加题目后重新保存问卷');
+      }
+    });
   });
 
   describe('deleteSurvey', () => {

diff --git a/server/src/modules/survey/controllers/survey.controller.ts b/server/src/modules/survey/controllers/survey.controller.ts
@@ -137,7 +137,7 @@ export class SurveyController {
       this.logger.error(error.message);
       throw new HttpException('参数有误', EXCEPTION_CODE.PARAMETER_ERROR);
     }
-    if(!surveyInfo.configData.dataConf.dataList.length){
+    if(!surveyInfo?.configData?.dataConf?.dataList?.length){
       this.logger.error('确少题目数据');
       throw new HttpException('请添加题目后重新保存问卷', EXCEPTION_CODE.PARAMETER_ERROR);
     }