chore(fixtures): scrub internal hosts and drop artifact CORS header from cassettes - #117
Merged
Merged
Conversation
Fivell
force-pushed
the
chore/fixture-placeholder-hosts
branch
from
June 14, 2026 08:57
d00c6c6 to
01b3e61
Compare
Cassettes recorded from live traffic kept two non-public hosts: - a real customer webhook host in the dids.yml callback_url response body — replaced with the RFC 2606 example.com placeholder; - an internal documentation host echoed back in Access-Control-Allow-Origin response headers (areas.yml, orders.yml, voice_out_trunk_regenerate_credentials.yml) — normalized to '*' for consistency with the 65 other fixtures. The server reflects the request Origin into this header (and omits it entirely when no Origin is sent, as the SDK does), so the recorded value is an artifact of capture rather than a meaningful API response. The header is response-only and is never used for request matching (see tests/bootstrap.php), so replay is unaffected.
Fivell
force-pushed
the
chore/fixture-placeholder-hosts
branch
from
June 14, 2026 09:18
01b3e61 to
9332486
Compare
…ttes The SDK sends no Origin header, so the live API returns no Access-Control-Allow-Origin in response (it only reflects an Origin back when one is sent). The recorded values were therefore artifacts of how the cassettes were captured — one even leaking an internal host. Removing the header makes the cassettes faithful to real SDK traffic and matches the other SDKs, whose fixtures carry no CORS headers at all. Response-header only, never used for request matching (tests/bootstrap.php), so replay is unaffected; 253 tests pass.
|
Fivell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up two issues in cassettes recorded from live traffic. Two commits:
1. Scrub non-public hosts
dids.ymlcallback_urlresponse body — replaced with the RFC 2606example.complaceholder2. Drop
Access-Control-Allow-Originentirely (all 69 occurrences, 19 files)The SDK sends no
Originheader, and the live API only reflects anOriginback when one is present — with noOriginit returns noAccess-Control-Allow-Originat all.