Improve MK2 frames handling#45
Merged
Merged
Conversation
Contributor
Author
|
Not ready yet |
bclermont
commented
Jul 22, 2024
| if checkChecksum(l, frame[0], frame[1:]) { | ||
| switch frame[0] { | ||
| case bootupFrameHeader: | ||
| m.setTarget() |
Contributor
Author
There was a problem hiding this comment.
setTarget() is only executed once at startup of invertergui process. this make sure it's executed everytime Victron is started even if invertergui is running while it happens
Contributor
Author
There was a problem hiding this comment.
What do you mean by "should be all" ?
Member
There was a problem hiding this comment.
Sorry I responded to this comment but in the wrong thread :D #44 (comment)
ncthompson
enabled auto-merge
December 2, 2025 08:50
ncthompson
approved these changes
Dec 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 45.16% 44.72% -0.45%
==========================================
Files 13 13
Lines 890 901 +11
==========================================
+ Hits 402 403 +1
- Misses 470 480 +10
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP to fix #44