-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Documentation improvements #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ef8df44
Documentation improvements
weiznich 80fef9a
Use a raw cfg flag for the unstable doc_cfg feature
weiznich 256b8a0
Apply suggestions from code review
weiznich a207878
Update diesel/src/connection/mod.rs
weiznich cd31d62
Update diesel/src/connection/mod.rs
weiznich 5054e03
Remove now unneeded feature
weiznich 87af53d
Fix compilation failures
weiznich d297652
Update compile test output
weiznich 8c07303
Another round of improvements
weiznich 7c3df9c
Adjust public API for newly added items + Minor fixes
weiznich e3f7367
Fix new transaction_manager tests
weiznich bfdb141
Post rebase fixes
weiznich 5c9cc51
Fix dead links if features are disabled
weiznich c1666e3
Improvements for the backend documentation
weiznich a7a2295
More minor documentation fixes
weiznich 3094060
Add documentation for the feature
weiznich 801ef03
post rebase fixes
weiznich ede99a3
Sage changed it name and wanted it be changed everywhere
weiznich e9d2c1d
Make most of the aliasing+join module private
weiznich b7541e4
Fix a compile test
weiznich 5d83a72
Remove `Connection::execute` as it is redundant
weiznich ad1ce71
Make `query_builder::nodes` private
weiznich 7d07f64
Replace more instances of `Connection::execute`
weiznich 54f6936
Remove the current branch from doc publishing again, as we don't need…
weiznich 5c429c4
Merge branch 'master' into diesel_2.0_documentation_update
weiznich 9f60834
Post merge fix
weiznich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| [package] | ||
| name = "diesel" | ||
| version = "2.0.0" | ||
| authors = ["Sean Griffin <[email protected]>"] | ||
| authors = ["Sage Griffin <[email protected]>"] | ||
| license = "MIT OR Apache-2.0" | ||
| description = "A safe, extensible ORM and Query Builder for PostgreSQL, SQLite, and MySQL" | ||
| readme = "README.md" | ||
| documentation = "https://docs.rs/diesel/" | ||
| homepage = "https://diesel.rs" | ||
| repository = "https://github.com/diesel-rs/diesel" | ||
| keywords = ["orm", "database", "blockchain", "sql"] | ||
| keywords = ["orm", "database", "sql"] | ||
| categories = ["database"] | ||
| edition = "2018" | ||
|
|
||
|
|
@@ -55,14 +55,17 @@ huge-tables = ["64-column-tables"] | |
| postgres = ["pq-sys", "postgres_backend"] | ||
| sqlite = ["libsqlite3-sys", "diesel_derives/sqlite"] | ||
| mysql = ["mysqlclient-sys", "url", "percent-encoding", "bitflags", "mysql_backend"] | ||
| without-deprecated = [] | ||
| with-deprecated = [] | ||
| without-deprecated = ["diesel_derives/without-deprecated"] | ||
| with-deprecated = ["diesel_derives/with-deprecated"] | ||
| network-address = ["ipnetwork", "libc"] | ||
| numeric = ["num-bigint", "bigdecimal", "num-traits", "num-integer"] | ||
| postgres_backend = ["diesel_derives/postgres", "bitflags", "byteorder"] | ||
| mysql_backend = ["diesel_derives/mysql", "byteorder"] | ||
| returning_clauses_for_sqlite_3_35 = [] | ||
| i-implement-a-third-party-backend-and-opt-into-breaking-changes = [] | ||
|
|
||
| [package.metadata.docs.rs] | ||
| features = ["postgres", "mysql", "sqlite", "extras"] | ||
| no-default-features = true | ||
| rustc-args = ["--cfg", "doc_cfg"] | ||
| rustdoc-args = ["--cfg", "doc_cfg"] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems somewhat dangerous. If I depend on such a backend, then I can also access those unstable features, and might use one without realizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The probably best other solution here is to use a raw cfg flag, right?
The other option that I see is to split up diesel itself into multiple crates and reexport only the stable api via a diesel crate. Everything else is then only exposed via a 0.x internal crate. I assume that this solution will cause problems as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, a raw cfg flag is how Tokio handles unstable features, but it does have the disadvantage that a crate cannot specify it, and that it must be specified by the person running
cargo build. (But that's also its advantage and why Tokio uses it over a feature.)