Skip to content

Symex guards: avoid unnecessary duplicate negation #8041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

We negated the right-hand side assigned to a guard symbol just so as to then negate the use of the guard symbol. Remove this duplicate negation.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the cleanup/symex-duplicate-neg branch 3 times, most recently from f7fec90 to 3736658 Compare November 16, 2023 15:06
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (22d25d1) to head (573a8e6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8041      +/-   ##
===========================================
- Coverage    80.39%   80.39%   -0.01%     
===========================================
  Files         1688     1688              
  Lines       207403   207402       -1     
  Branches        73       73              
===========================================
- Hits        166752   166749       -3     
- Misses       40651    40653       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig force-pushed the cleanup/symex-duplicate-neg branch 4 times, most recently from bc3bad6 to a5259ef Compare November 17, 2023 16:41
@tautschnig tautschnig force-pushed the cleanup/symex-duplicate-neg branch from a5259ef to 2b6106b Compare February 13, 2024 11:28
@tautschnig tautschnig self-assigned this Feb 13, 2024
@tautschnig tautschnig force-pushed the cleanup/symex-duplicate-neg branch from 2b6106b to 150402c Compare April 26, 2024 10:03
@tautschnig tautschnig force-pushed the cleanup/symex-duplicate-neg branch from 150402c to 92af47a Compare July 28, 2025 18:00
We negated the right-hand side assigned to a guard symbol just so as to
then negate the use of the guard symbol. Remove this duplicate negation.
@tautschnig tautschnig force-pushed the cleanup/symex-duplicate-neg branch from 92af47a to 573a8e6 Compare July 29, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants