Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line number for files with no newline #8558

Merged
merged 1 commit into from
Feb 19, 2025
Merged

line number for files with no newline #8558

merged 1 commit into from
Feb 19, 2025

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 6, 2025

The parser sets the line number used for error messages once reaching a newline. This fixes the logic for the case that the input file does not have a newline.

This is only visible on .i files, as the preprocessor adds a newline when there isn't one on .c files.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening added the bugfix label Jan 6, 2025
@kroening kroening force-pushed the parser_line_no branch 2 times, most recently from cc07d16 to 6ee9f5b Compare February 11, 2025 20:14
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (0fc8a49) to head (a262c00).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8558   +/-   ##
========================================
  Coverage    79.63%   79.63%           
========================================
  Files         1733     1733           
  Lines       197686   197690    +4     
  Branches     18226    18196   -30     
========================================
+ Hits        157418   157422    +4     
  Misses       40268    40268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review February 17, 2025 16:17
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing one bug. Eventually we also need to figure out how to address the other line-number-related issue in #8257.

file_with_no_newline.i

^file_with_no_newline\.i:[01]:1: error: .*$
^EXIT=1$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
^EXIT=1$
^EXIT=(1|64)$

to make MSVC tests pass.

The parser sets the line number used for error messages once reaching a
newline.  This fixes the logic for the case that the input file does not
have a newline.

This is only visible on .i files, as the preprocessor adds a newline when
there isn't one on .c files.
@kroening kroening merged commit be99f47 into develop Feb 19, 2025
40 of 41 checks passed
@kroening kroening deleted the parser_line_no branch February 19, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants