Conversation
3e90cae to
e67da47
Compare
cc07d16 to
6ee9f5b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8558 +/- ##
========================================
Coverage 79.63% 79.63%
========================================
Files 1733 1733
Lines 197686 197690 +4
Branches 18226 18196 -30
========================================
+ Hits 157418 157422 +4
Misses 40268 40268 ☔ View full report in Codecov by Sentry. |
tautschnig
approved these changes
Feb 18, 2025
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
Thank you for fixing one bug. Eventually we also need to figure out how to address the other line-number-related issue in #8257.
| file_with_no_newline.i | ||
|
|
||
| ^file_with_no_newline\.i:[01]:1: error: .*$ | ||
| ^EXIT=1$ |
Collaborator
There was a problem hiding this comment.
Suggested change
| ^EXIT=1$ | |
| ^EXIT=(1|64)$ |
to make MSVC tests pass.
6ee9f5b to
8a155c4
Compare
The parser sets the line number used for error messages once reaching a newline. This fixes the logic for the case that the input file does not have a newline. This is only visible on .i files, as the preprocessor adds a newline when there isn't one on .c files.
8a155c4 to
a262c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser sets the line number used for error messages once reaching a newline. This fixes the logic for the case that the input file does not have a newline.
This is only visible on
.ifiles, as the preprocessor adds a newline when there isn't one on.cfiles.