Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 (Arm 64-bit) CI job #8572

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Jan 20, 2025

Run regression tests and build release package using GitHub's newly (publicly) available aarch64 runner.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 50.54945% with 45 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (66004dc) to head (3d55782).

Files with missing lines Patch % Lines
src/util/simplify_expr.cpp 34.28% 23 Missing ⚠️
src/cpp/cpp_internal_additions.cpp 25.00% 9 Missing ⚠️
src/ansi-c/goto-conversion/builtin_functions.cpp 66.66% 8 Missing ⚠️
src/ansi-c/c_typecheck_expr.cpp 50.00% 4 Missing ⚠️
src/ansi-c/ansi_c_internal_additions.cpp 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8572      +/-   ##
===========================================
- Coverage    78.71%   78.16%   -0.55%     
===========================================
  Files         1732     1732              
  Lines       199536   200969    +1433     
  Branches     18281    18250      -31     
===========================================
+ Hits        157057   157086      +29     
- Misses       42479    43883    +1404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the arm-ci branch 3 times, most recently from 97ea138 to 04bf0cd Compare January 20, 2025 15:30
@tautschnig tautschnig marked this pull request as draft January 20, 2025 15:37
@tautschnig tautschnig assigned tautschnig and unassigned peterschrammel and TGWDB Feb 7, 2025
GCC on Arm-only supports additional vector types that compile to
hardware-supported types.
This prepares for Arm64 runs: CVC5 CI releases CVC5 for Arm64 starting
from 1.2.0.
This isn't portable to non-x86 architectures.
The intervening zero-extension does not alter the semantics and hinders
the application of `skip_typecast`.
aarch64 ABI (section 7.1.4) mandates that va_list is a struct with
particular members. The C library model was fixed in diffblue#8366, but we
didn't yet implement the struct type support in goto conversion.
Run regression tests and build release package using GitHub's newly
(publicly) available aarch64 runner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants