Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup type conversions in java_bytecode_parsert::read #8584

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

We can safely read signed values and don't need to defer the type conversion to the call site.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We can safely read signed values and don't need to defer the type
conversion to the call site.
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (66004dc) to head (f518b4b).

Files with missing lines Patch % Lines
jbmc/src/java_bytecode/java_bytecode_parser.cpp 71.42% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8584      +/-   ##
===========================================
- Coverage    78.71%   78.58%   -0.14%     
===========================================
  Files         1732     1732              
  Lines       199536   199870     +334     
  Branches     18281    18247      -34     
===========================================
+ Hits        157057   157058       +1     
- Misses       42479    42812     +333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants