Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub releases using spotless-changelog #2196

Merged
merged 9 commits into from
Aug 25, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.diffplug.spotless-changelog 3.0.2 -> 3.1.2 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/com.diffplug.spotless-changelog-3.x branch from 7703207 to d6c68e6 Compare July 6, 2024 16:09
@renovate renovate bot changed the title Update plugin com.diffplug.spotless-changelog to v3.1.1 Update plugin com.diffplug.spotless-changelog to v3.1.2 Jul 6, 2024
Copy link
Contributor Author

renovate bot commented Jul 7, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Goooler Goooler requested a review from nedtwigg July 7, 2024 01:00
@nedtwigg nedtwigg changed the title Update plugin com.diffplug.spotless-changelog to v3.1.2 Create GitHub releases using spotless-changelog Jul 8, 2024
@nedtwigg
Copy link
Member

nedtwigg commented Jul 8, 2024

@nedtwigg nedtwigg merged commit 45d73ec into main Aug 25, 2024
29 checks passed
@nedtwigg nedtwigg deleted the renovate/com.diffplug.spotless-changelog-3.x branch August 25, 2024 20:08
Comment on lines +25 to +26
tagMessage "${kind} v{{version}}\n\n{{changes}}"
runAfterPush "gh release create ${kind}/{{version}} --title '${releaseTitle} v{{version}}' --notes-from-tag"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TIL.

@Goooler Goooler linked an issue Aug 26, 2024 that may be closed by this pull request
@@ -18,13 +22,15 @@ spotlessChangelog {
branch 'release'
tagPrefix "${kind}/"
commitMessage "Published ${kind}/{{version}}" // {{version}} will be replaced
tagMessage "${kind} v{{version}}\n\n{{changes}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ${kind} v{{version}}\n looks redundant.

image image

@nedtwigg
Copy link
Member

I agree, it is a workaround for

GitHub recognized it as a bug and pushed a fix

The fix was released a week ago

We can remove this nitpick from the existing releases pretty easily, and improve the tag within the copy too. Not sure how long until the latest Github CLI is on all the runners, probably a week is enough...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we create releases from tags?
2 participants