Remove locked routines #6
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@digama0 So,
parking_lotstill requiresstd, which is annoying. This PR provides a potential fix.However, I suggest we should completely remove the
*_lockedthings. It is hardly useful to provide such locked routines. Users cannot call it multiple times, even if it is locked. Users still struggle to maintain the status to check ifLeanis already initialized. Also, the user may initialize their own pieces betweenlean_initializeandio_mark_end_initialization, where exclusivity is required during the whole time, but these*_lockedthings simply release the lock after the first function call.As in this low-level
lean-sys,I think just providing theunsafeinitialization routine is fine.