Skip to content
This repository was archived by the owner on Dec 3, 2019. It is now read-only.

Refactor as v2.0 #18

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

Refactor as v2.0 #18

wants to merge 24 commits into from

Conversation

@Jalle19
Copy link
Contributor

@Jalle19 Jalle19 commented Nov 27, 2017

Fixes #16 and modernizes the library somewhat:

  • Minimum required PHP version 7.1
  • Updated league/fractal dependency
  • Replaced custom exceptions with SPL exceptions
  • Added support for actually using callables as transformers
  • Drop facade support

Sam Stenvall added 10 commits November 27, 2017 20:51
Ignore the .idea directory and composer.phar
455225c
Add myself to authors in composer.json
5978b25
Bump dependencies, we'll be using PHP 7.1 from now on
d58d364 
Also changed to use the latest version of league/fractal
Remove an unused include
99fd2cb
Drop facade support, it's neither documented nor wanted
3600777
Remove pointless check, static typing forbids this anyway
9a88a10
Update generated Codecept files
28d43df
Refactor setResourceKey and setResourceClass to throw SPL exceptions
4d6b445 
This allows us to remove our custom InvalidArgument exception class. Static type-hinting removes the need for some checks and exception throwing too
Replace NotApplicable with \InvalidArgumentException
f8bccc2
Replace FractalBuilder constants with references directly to the clas…
984cee9 
…s names
@Jalle19 Jalle19 requested a review from crisu83 November 27, 2017 22:55
Sam Stenvall added 14 commits November 28, 2017 08:30
Use @return $this instead of the interface name
122ca93 
Makes it easier for people who extend the class to use fluent setters
Make more setters fluent
c88cc3c
Remove pointless private setters from FractalBuilder
6ee31a5
Change some isset() checks into null checks, remove bogus isset() che…
0253798 
…ck on includes
Make item() and collection() actually usable with callables
9d1124a 
The static class type-hint prevented callables from being used
Ignore log files that can be generated by failing tests
325dd48
Add visibility modifier to COǸFIG_KEY
3a2ea58
Add static type-hints where applicable
7821ccb
Update the Travis build matrix to only include 7.1 and 7.2
3a2b37d
Remove unnecessary before_script commands from .travis.yml
4561a21
Reformat files (removed double line between methods etc.)
983f4aa
Exclude the tests/ directory from StyleCI checking
47715e7
Update some README badges
49d15c2
Update the README to reflect changed requirements etc.
5f4f0c1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisu83 crisu83 Awaiting requested review from crisu83

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jalle19