Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2926: Redesign of search feedback in web #3035

Draft
wants to merge 2 commits into
base: 2926-fallback-language-in-search
Choose a base branch
from

Conversation

LeandraH
Copy link
Contributor

@LeandraH LeandraH commented Jan 9, 2025

Short description

This is the implementation of the redesign of the search feedback in web

Proposed changes

  • When there are no search results, the text makes it clearer that we also searched in the fallback language, and a suggestion to try a different language.
  • When there are no search results, there is a very clear CTA to open the feedback form if the user thinks there is information missing anyway.
  • The design also calls for the number of search results to disappear if there aren't any but I decided against that so that a screen reader can still yell at someone to stop typing if they already have no results (IGAPP-886: Announce number of search results in screen reader #2352)

Side effects

  • The sad smiley in the search feedback disappears (though I'm not sure that qualifies as a side effect since that's the design)

Testing

You can switch the app to English and search for "alleinerziehend".

Resolved issues

Partially fixes: #2926


@LeandraH LeandraH marked this pull request as draft January 16, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant