2881: Fix weird modal bug #3037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeandraH
requested review from
steffenkleinle,
f1sh1918,
bahaaTuffaha and
lunars97
as code owners
steffenkleinle
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
I couldn't really find anything about why but our
Modalcenters its content (correctly) on Android for rtl and ltr and on iOS for ltr. On iOS for rtl, the content is aligned to the right. This fixes it by using margin instead of padding. It makes no sense to me but I decided an hour of googling is enough for a very minor bug.Proposed changes
Side effects
Testing
Test on iOS, set the device language to a rtl language (e.g. Arabic), go to the map and open the overlay with the POI filters. It should be centered now.
Resolved issues
Fixes: #2881