Skip to content

Conversation

@kishlay-singh-DO
Copy link
Contributor

No description provided.

@dkrieger
Copy link

fwiw, it would be better to internally standardize representing versions without the "v" prefix, then have a formatter singleton or the like that you can use to format it for different use cases. if this PR fixes the presenting issue, so be it, as the action is presently broken, but looking at the surrounding code does not inspire confidence

@kishlay-singh-DO
Copy link
Contributor Author

kishlay-singh-DO commented Sep 24, 2025

fwiw, it would be better to internally standardize representing versions without the "v" prefix, then have a formatter singleton or the like that you can use to format it for different use cases. if this PR fixes the presenting issue, so be it, as the action is presently broken, but looking at the surrounding code does not inspire confidence

@dkrieger That is a good suggestion given github file path creates the link without the "v" prefix which was the major reason that the surrounding block has to be handled that way. The "v" prefix change will be a big change for us because that'll have to go to all open source tooling that we have. What part of it looks error prone to you, happy to fix it to make the code more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants