Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔️ Add test for cli #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

✔️ Add test for cli #49

wants to merge 2 commits into from

Conversation

drts01
Copy link
Member

@drts01 drts01 commented Apr 17, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #49 (c99339a) into master (c95e6f5) will increase coverage by 17.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #49       +/-   ##
===========================================
+ Coverage   53.33%   71.11%   +17.77%     
===========================================
  Files           1        1               
  Lines          45       45               
  Branches        2        2               
===========================================
+ Hits           24       32        +8     
+ Misses         20       12        -8     
  Partials        1        1               
Impacted Files Coverage Δ
fizzbuzzx.py 71.11% <100.00%> (+17.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95e6f5...c99339a. Read the comment docs.

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 22, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 0.44 ⭐ 0.40 ⭐ -0.04 👍
Method Length 19.47 ⭐ 20.17 ⭐ 0.70 👎
Working memory 4.82 ⭐ 4.80 ⭐ -0.02 👍
Quality 93.18% 93.13% -0.05% 👎
Other metrics Before After Change
Lines 167 174 7
Changed files Quality Before Quality After Quality Change
fizzbuzzx.py 92.48% ⭐ 91.78% ⭐ -0.70% 👎
test_fizzbuzzx.py 94.39% ⭐ 95.01% ⭐ 0.62% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
test_fizzbuzzx.py test_fizzbuzz 0 ⭐ 31 ⭐ 12 😞 75.95% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant