Repository navigation
verify: require trusted timestamps and reject unsafe byte ranges - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An untrusted, backdated RFC 3161 token could make an expired signing certificate validate and turn later revocation into a warning. Separately, a crafted PDF
/ByteRangecould reach an unchecked allocation and panic the fluent verification API before cryptographic signature verification.This change closes both paths:
TimestampTrusted, rather than relying on the time-source label. Configured roots and explicit embedded/self-signed trust remain supported.Validation:
go test -race ./...passes locally.golangci-lint run ./...reports 0 issues; formatting and diff checks pass.The repository CI runs external pdfcpu/DSS validation and the downloaded corpus checks; these were not rerun locally. This PR does not mark either follow-up issue as fixed in a released version.