Move test code into a _test.go file#14
Merged
vanbroup merged 2 commits intodigitorus:masterfrom Jul 25, 2025
Merged
Conversation
The lack of a _test.go suffix on the dsa test prevents dead code elimination from removing the test file from builds. This results in testing symbols leaking into every downstream binary that depends on pkcs7 either directly or transitively.
Author
|
Hello! @vanbroup, I am a first time contributor to this project, I noticed that you have helped review previous PRs. Is this a PR that you would be able to help provide feedback on? Thank you! |
8372c42 to
79502f3
Compare
79502f3 to
5c7b21b
Compare
vanbroup
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of a _test.go suffix on the dsa test prevents dead code elimination from removing the test file from builds. This results in testing symbols leaking into every downstream binary that depends on pkcs7 either directly or transitively. For an example see the following dependency tree.