Skip to content

Modernize GitHub Actions workflows and deprecated Go code patterns#17

Merged
vanbroup merged 15 commits intodigitorus:masterfrom
rosstimothy:tross/modernization
Jul 30, 2025
Merged

Modernize GitHub Actions workflows and deprecated Go code patterns#17
vanbroup merged 15 commits intodigitorus:masterfrom
rosstimothy:tross/modernization

Conversation

@rosstimothy
Copy link
Copy Markdown

@rosstimothy rosstimothy commented Jul 29, 2025

This is cherry-picks the entirety of #15, while updating it to address existing build issues, remove linter exceptions, update golangci-lint to use v2, and update CI to use the golangci-lint action.

Copilot AI and others added 12 commits July 29, 2025 13:50
@rosstimothy
Initial plan
a7c789e
@vanbroup @rosstimothy
Update GitHub Actions workflows and modernize deprecated Go code patt…
cf7e188 
…erns

Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Fix Makefile staticcheck path and optimize build targets
661b7a3 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Add coverage.out to .gitignore to exclude build artifacts
32d67f0 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Update Go version to 1.24 and replace staticcheck with golangci-lint
138206c 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Rename verify_test_dsa.go to dsa_test.go to follow Go naming conventions
72707fb 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Fix CI workflow and SHA1 compatibility issues for Go 1.24
0d7983c 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Fix CI workflow and address code quality improvements
57bd227 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Fix DSA signature verification test failures across Go versions
dc6b33a 
Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@vanbroup @rosstimothy
Remove DSA signature verification functionality, allow parsing with p…
1390b41 
…roper error handling

Co-authored-by: vanbroup <722070+vanbroup@users.noreply.github.com>
@rosstimothy
Fix tests
70b1843 
Removes duplicated dsa certificate declarations causing build
failures, ensures that all errors in tests are handled, and moves
all SHA1 tests behind a go1.17 build tag.
@rosstimothy
Update golangci-lint and ci workflow
a136a97 
Removes linter bypasses and updates CI to use the golangic-lint
action instead of manually installing it.
@rosstimothy
Copy link
Copy Markdown
Author

rosstimothy commented Jul 29, 2025

@vanbroup I cherry-picked all the commits from #15 here and made a few updates to get the tests to run, remove exceptions for a few linters, updated the golangci-lint version, and use the golangci-lint action. Please let me know if you'd like to see any changes made.

@rosstimothy rosstimothy marked this pull request as ready for review July 29, 2025 20:07
rosstimothy
rosstimothy commented Jul 29, 2025
View reviewed changes
Comment thread sign_legacy_test.go
@rosstimothy rosstimothy force-pushed the tross/modernization branch from 1b6c741 to d4636af Compare July 30, 2025 13:16
@rosstimothy rosstimothy requested a review from vanbroup July 30, 2025 13:22
vanbroup
vanbroup reviewed Jul 30, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
@rosstimothy rosstimothy requested a review from vanbroup July 30, 2025 15:21
@vanbroup vanbroup merged commit ffadbf3 into digitorus:master Jul 30, 2025
12 checks passed
@vanbroup
Copy link
Copy Markdown
Member

vanbroup commented Jul 30, 2025

Thanks @rosstimothy ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanbroup vanbroup vanbroup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rosstimothy @vanbroup