Ensure NULL-termination of string when unescaping single-quotes #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The for-loop is copying a string character by character and replacing `''` with `'` by skipping a character if the current and next one are both `'`. When this replacement doesn't occur then the target string will be filled completly without a `\0' terminator at the end of the string.
acritox
force-pushed
the
fix-null-termination
branch
from
a5395d4 to
f323be3
Compare
dimitri
approved these changes
Oct 30, 2023
|
Thanks @acritox for your contribution, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for-loop is copying a string character by character and replacing
''with'by skipping a character if the current and next one are both
'. When thisreplacement doesn't occur then the target string will be filled completly
without a `\0' terminator at the end of the string.
here's a (redacted) screenshot showing the effect of this bug:
which then results in an apply error like:
or it could result in corrupted data if if the uninitialized memory happens to be valid UTF-8 bytes/characters for JSON strings