Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compose plugin of docker #859

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

hanefi
Copy link
Contributor

@hanefi hanefi commented Aug 2, 2024

`docker-compose`` is an external tool written in python and is deprecated for a while. Github actions also removed support for that recently.

docker cli has a plugin named compose that is available as a command of the cli as in docker compose.

docker-compose and docker compose do not have same specifcations and it is not always a trivial task to migrate from one to another. This commit will only change all the references to the docker-compose to docker compose in our codebase.

Github Actions removed support for docker-compose in actions/runner-images#10368

More details available at https://docs.docker.com/compose/intro/history/

Closes: #847

`docker-compose`` is an external tool written in python and is deprecated
for a while. Github actions also removed support for that recently.

docker cli has a plugin named compose that is available as a command of
the cli as in `docker compose`.

`docker-compose` and `docker compose` do not have same specifcations and
it is not always a trivial task to migrate from one to another. This
commit will only change all the references to the `docker-compose` to
`docker compose` in our codebase.
@hanefi hanefi requested a review from dimitri August 2, 2024 13:57
@dimitri dimitri added this to the v0.17 milestone Aug 2, 2024
@dimitri dimitri merged commit c637f09 into dimitri:main Aug 2, 2024
19 checks passed
@hanefi hanefi deleted the use-compose-plugin-of-docker branch August 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants