-
-
Notifications
You must be signed in to change notification settings - Fork 39
Reorder navigation and title setting in blueprints #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Does reordering these have the potential for slower systems to display the view, it sees the old values, and then the new values update or does the action happen so quickly that that is not a possibility? I think you're wanting to clear the title in the integration's navigate service but what about other stuff that might be being displayed? |
|
I think it just happens so quickly / the view takes a moment to load that it isn't even noticed. If you are worried about that we can split the set state calls in two, allowing the title to be set after PR dinki/view_assist_integration#163 has been tested to perform as expected, but as mentioned above, most of these BPs still need to be tested if you'd like to have a go. |
|
Yeah I guess it would not kill us to break out just the title so that it is set after and keep the other stuff where it is now. I may be overthinking it but I really want to ensure we don't see stale data on low power machines.
I'm going to have to carve out some time to get this tested. Hopefully it won't take too much time. We are a madhouse at work and weekends pretty nuts too but will try to get this going. |
|
I've split the set state commands to break out just the title as requested. Still a draft, as I've yet to test the following:
|
PR is a draft as testing is still needed. Testing should show that the titles display as intended.
Reorders
navigateandset_statecalls in blueprints to set titles after navigation instead of before. This ensures titles survive the navigation auto-clear feature added in the integration.Addresses issue dinki/view_assist_integration#144
Requires PR dinki/view_assist_integration#163 that implements auto-clear of title attribute during navigation. These changes work together:
titleduringasync_browser_navigate()Changes
Updated blueprints to set titles AFTER navigation:
Ask AI: Reorderblueprint removedset_stateandnavigatecalls for title settingRemoved explicit title clearing workarounds:
title: ""manual clearingtitle: ""manual clearingtitle: ""from all camera sequencesNew Pattern
Blueprints that need contextual titles now follow the pattern: