Skip to content

Add external link handling to open in new tab #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

Add external link handling to open in new tab #237

merged 4 commits into from
Apr 15, 2025

Conversation

Bashamega
Copy link
Contributor

fixes #223

@Bashamega Bashamega requested a review from a team as a code owner March 13, 2025 13:52
@vercel Vercel
Copy link

vercel bot commented Mar 13, 2025

@Bashamega is attempting to deploy a commit to the Directus Team on Vercel.

A member of the Team first needs to authorize it.

@Bashamega Bashamega marked this pull request as draft March 13, 2025 13:56
@Bashamega Bashamega marked this pull request as ready for review March 13, 2025 13:59
@vercel Vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 8:14am

@hola-soy-milk
Copy link
Contributor

hola-soy-milk commented Mar 17, 2025 •
edited
Loading

Hi @Bashamega! Thanks so much for this.

I'm afraid I couldn't get the external links, such as in this example, to work.

Also, the external links to github and others in the layout didn't open new tabs either.

Could you please take a look?

hola-soy-milk
hola-soy-milk approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@hola-soy-milk hola-soy-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to confirm this is now working! Thanks so much!

@hola-soy-milk hola-soy-milk merged commit 51118b2 into directus:main Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hola-soy-milk hola-soy-milk hola-soy-milk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open external links in new tabs
2 participants
@Bashamega @hola-soy-milk