Skip to content

Try to fix powershell text background #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
o-sdn-o merged 1 commit into from
Mar 6, 2026
Merged

Try to fix powershell text background #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/netxs/desktopio/consrv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2226,7 +2226,8 @@ struct impl : consrv
.inv(!!(attr & COMMON_LVB_REVERSE_VIDEO ))
.und(!!(attr & COMMON_LVB_UNDERSCORE ))
.ovr(!!(attr & COMMON_LVB_GRID_HORIZONTAL));
if (auto colors = attr & 0x00FFu) // Use "default color" if fgc == bgc == 0.
auto colors = attr & 0x00FFu;
if (colors != (ui16)(7 + (0 << 4))) // Use "default color" if fgc==7 and bgc==0.
{
argb::set_indexed_color(c.fgc(), netxs::swap_bits<0, 2>(colors & 0x000Fu)); // FOREGROUND_ . . .
argb::set_indexed_color(c.bgc(), netxs::swap_bits<0, 2>(colors >> 4)); // BACKGROUND_ . . .
Expand All @@ -2238,14 +2239,18 @@ struct impl : consrv
auto attr = ui16{};
auto fgc = brush.fgc();
auto bgc = brush.bgc();
if (fgc != bgc || fgc.token != 0) // Leave fg and bg empty if brush is default color (token==0).
if (fgc != bgc || fgc.token != 0) // Set fg and bg if brush has non-default color (token!=0).
{
auto fgcx = argb::is_indexed_color(fgc);
auto bgcx = argb::is_indexed_color(bgc);
if (fgcx) fgcx = netxs::swap_bits<0, 2>(fgcx - 1); else fgcx = 7; // Fallback to BW for non-index colors.
if (bgcx) bgcx = netxs::swap_bits<0, 2>(bgcx - 1); else bgcx = 0; //
attr = (ui16)(fgcx + (bgcx << 4));
}
else
{
attr = (ui16)(7 + (0 << 4));
}
if (brush.inv()) attr |= COMMON_LVB_REVERSE_VIDEO;
if (brush.und()) attr |= COMMON_LVB_UNDERSCORE;
if (brush.ovr()) attr |= COMMON_LVB_GRID_HORIZONTAL;
Expand Down Expand Up @@ -3985,9 +3990,9 @@ struct impl : consrv
packet.reply.fullscreen = faux;
packet.reply.popupcolor = FOREGROUND_GREEN | FOREGROUND_INTENSITY;
auto mark = console.brush;
if (mark.fgc().token == 0 && mark.bgc().token == 0) // Use fgc=bgc=0 as default color.
if (mark.fgc().token == 0 && mark.bgc().token == 0) // Use fgc=7 and bgc=0 as default color.
{
packet.reply.attributes = 0;
packet.reply.attributes = (ui16)(7 + (0 << 4));
}
else
{
Expand Down