Add git submodule support (to detect submodule repos) #272
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that git submodules were not getting detected by
vcs
. Believe the issue comes down to file structure and type.(Also faced in issue: #198)
Typical git repo
Submodule repo
Contents of
.git
file (the one inside the submodule_repo):So effectively, submodules don't have
.git
directory of their own but rather a.git
linked file that links to the directory in the outer.git
directory.Currently, it appears that vcstool is designed to determine if a repo is a git repo by checking for only a
.git
directory:vcstool/vcstool/clients/git.py
Line 31 in daf3893
Tried to fix this here. The submodules now seem to get detected as git repos. Hope there would be no unintended consequences though?