Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer)[reduction,doall]: minor fix regarding considered metadata #660

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(explorer)[reduction,doall]: minor fix regarding considered metadata #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion discopop_explorer/pattern_detectors/do_all_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,9 @@ def __check_loop_dependencies(
)
cond_2 = len([cf for cf in called_functions_lineids if cf in dep.metadata_inter_call_dep]) > 0
cond_3 = len([t for t in parent_loops if t in dep.metadata_inter_iteration_dep]) > 0
if cond_1 or cond_2 or cond_3:
cond_4 = root_loop.start_position() in dep.metadata_inter_iteration_dep
# if cond_1 or cond_2 or cond_3:
if cond_2 or cond_4:
return True
# if it is an intra iteration dependency, it is problematic if it belongs to a parent loop
else:
Expand Down
4 changes: 3 additions & 1 deletion discopop_explorer/pattern_detectors/reduction_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,9 @@ def __check_loop_dependencies(
)
cond_2 = len([cf for cf in called_functions_lineids if cf in dep.metadata_inter_call_dep]) > 0
cond_3 = len([t for t in parent_loops if t in dep.metadata_inter_iteration_dep]) > 0
if cond_1 or cond_2 or cond_3:
cond_4 = root_loop.start_position() in dep.metadata_inter_iteration_dep
# if cond_1 or cond_2 or cond_3:
if cond_2 or cond_4:
return True
elif dep.dtype == DepType.WAR:
# check WAR dependencies
Expand Down
Loading