Add Discord patches #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- libva 1.10 has no support for AV1. - Some h265 fields are missing in libva 1.10, plus there's no VAAPI H.265 encoder in cros-codecs yet anyways. - This project actually uses minigbm, and we don't use it, so we can just disable it. - c2-wrapper is only useful for Android
Related to chromeos/cros-libva#31
TODO: implement it on the V4L2 encoder
Frame skipping may be useful for real-time, and bit stuffing messes with rate control.
Currently, only handle those for the h264 encoder
This way we can avoid extra complications with using the constructor with VideoFrame and use plain VAAPI surfaces borrowed as input.
Pushing new SPS/PPS on P-frames might confuse some decoders.
Our main use-case is importing dmabufs into surfaces for encoding.
mikepavone
approved these changes
Aug 27, 2025
| self.resolution().height, | ||
| // TODO: Should we add USAGE_HINT_ENCODER support? | ||
| Some(UsageHint::USAGE_HINT_DECODER), | ||
| Some(UsageHint::USAGE_HINT_ENCODER), |
There was a problem hiding this comment.
I guess this is fine for us since we're only using this for encoding, but looks like this code is used for both encode and decode generally. Seems like it would be better to pass in a parameter for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H.265 encoder in cros-codecs yet anyways.
just disable it.
Bump cros-libva to 0.0.13
Add FrameMetadata::force_idr
Use Arc<Display>: related to Allow Display to be used by multiple threads chromeos/cros-libva#31
Add RateControl::VariableBitrate and implement it for VAAPI encoder
vaapi: allow frame skip and disable bit stuffing
vaapi: add rc_buffer_size and max_frame_size to Tunings
vaapi: add new_native_vaapi constructor to H264 encoder
encoder: downgrade log from info to debug
encoder: do not push new SPS/PPS when applying tunings
video_frame: use HINT_ENCODER when importing dmabuf into vaapi
vaapi: add quality tuning and use in h.264 encoder
vaapi: add packed slice header for h.264 encoder