Skip to content

Added nameplate documentation #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025
Merged

Added nameplate documentation #7614

merged 3 commits into from
Jun 13, 2025

Conversation

anthonydiscord
Copy link
Contributor

Documents collectibles on a user and nameplate in collectibles

@anthonydiscord anthonydiscord requested a review from a team as a code owner June 12, 2025 22:33
@anthonydiscord anthonydiscord requested review from markmandel and removed request for a team June 12, 2025 22:33
@advaith1
Copy link
Contributor

superseding #7506?

"sku_id": "2247558840304243311",
"asset": "https://cdn.discordapp.com/fakelocation/asset.webm",
"label": "",
"palette": "#5865F2"
Copy link
Contributor

@advaith1 advaith1 Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like palette is some sort of string enum, not a hex code. can the possible values be documented with their meaning?

  collectibles: {
    nameplate: {
      sku_id: '1349849614198505602',
      asset: 'nameplates/nameplates/twilight/',
      label: 'COLLECTIBLES_NAMEPLATES_TWILIGHT_A11Y',
      palette: 'cobalt'
    }
  }

also asset isn't a full url, it's just the path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into getting the palette values documented! We're going to leave the label blank for now until it returns a value.

@anthonydiscord anthonydiscord merged commit 8e9bd1c into main Jun 13, 2025
4 checks passed
@anthonydiscord anthonydiscord deleted the anthony/nameplates branch June 13, 2025 22:33
sebm253 added a commit to disgoorg/disgo that referenced this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants