-
Notifications
You must be signed in to change notification settings - Fork 4
FEATURE: Add support for image attachments #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
angusmcleod
wants to merge
10
commits into
discourse:main
Choose a base branch
from
angusmcleod:add_media_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds good to merge this separately from outbound attachments. Let me know when it is ready for review. (Given Draft status and conflict, I am guessing it is not yet ready.) Thanks @angusmcleod |
6f90bf9
to
9e0b66f
Compare
2a355a2
to
eb18a1e
Compare
@pmusaraj I've added attachment publication support to this PR. It's ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmusaraj This adds support for image attachments in the simplest way possible. This is the first step in adding media support.
Next steps after this are:
Notes:
Document
attachment types for images (instead ofImage
).