Skip to content

FEATURE: Add support for image attachments #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

angusmcleod
Copy link
Contributor

@angusmcleod angusmcleod commented Mar 20, 2025

@pmusaraj This adds support for image attachments in the simplest way possible. This is the first step in adding media support.

Next steps after this are:

  • Potentially improve the attachment - post - upload relationship. This likely will be needed for outgoing support.
  • Improve image feature support, e.g. Mastodon's focalPoint), blurhash, and width/height attributes.
  • Add more tests, e.g. integration (end to end).

Notes:

  • Some platforms use Document attachment types for images (instead of Image).
  • Attachments can be added to Objects other than Notes or Articles (e.g. Mastodon uses it for certain profile attributes), and we may want to support other types of attachments in the future (hence the need for a ploymorphic association).

@angusmcleod angusmcleod marked this pull request as draft March 20, 2025 13:24
@pmusaraj
Copy link
Contributor

Sounds good to merge this separately from outbound attachments. Let me know when it is ready for review. (Given Draft status and conflict, I am guessing it is not yet ready.)

Thanks @angusmcleod

@angusmcleod angusmcleod changed the title FEATURE: Add support for processing incoming attachments FEATURE: Add support for image attachments Apr 7, 2025
@angusmcleod angusmcleod marked this pull request as ready for review April 7, 2025 10:19
@angusmcleod
Copy link
Contributor Author

angusmcleod commented Apr 7, 2025

@pmusaraj I've added attachment publication support to this PR. It's ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants