DEV: Resolve excerpt issue in specs #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
commented
Apr 2, 2025
| @@ -29,6 +34,7 @@ | |||
|
|
|||
| it "does not show the topic excerpts by default" do | |||
| visit("/docs") | |||
| expect(page).to have_css(".topic-list-item", count: 2) | |||
| expect(page).to have_no_css(".topic-excerpt") | |||
There was a problem hiding this comment.
This was passing previously because the assertion would run before the page is actually loaded.
If the page loaded very quickly for some reason, then the assertion would fail correctly because of the interaction with the tooltips plugin.
Adding a have_css assertion beforehand ensures that rendering has completed before running the have_no_css check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.