FIX: Support URL-based SAML attribute names from IdPs - #148
Merged
Conversation
We use `:` as a special character for defining configuration mappings. This was clashing with the colons in URL-based attribute names. The solution is to only split on the first comma (when the saml attribute is on the right-hand-side), or the last comma (when the saml attribute is on the left-hand-side)
nattsw
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
:as a special character for defining configuration mappings. This was clashing with the colons in URL-based attribute names. The solution is to only split on the first colon (when the saml attribute is on the right-hand-side), or the last colon (when the saml attribute is on the left-hand-side)