Repository navigation
Avoid repeating identical lowercase extension lookups - #64
Closed
OskarEichler wants to merge 1 commit into
Closed
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Merged
Member
|
I have this (and the other 2 prs) sorted in: #67 needed to do a bunch of cleanup 🤗 |
SamSaffron
added a commit
that referenced
this pull request
Sep 2, 2026
Require Ruby 3.3 and refresh the bundled MIME database from mime-types-data 3.2026.0701. Use byte offsets for Unicode-safe database lookups, avoid duplicate lowercase misses, and preserve extension priorities when rebuilding the database. Update CI to cover current Ruby implementations and runners. closes #64, #65, #66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip the fallback database lookup when downcasing an unknown extension leaves it unchanged. Preserve exact-case precedence and mixed-case fallback.
Reproduction and measurement
Instrument Db#lookup_by_extension and call MiniMime.lookup_by_extension('unknown'): previously two lookups of the same key, now one.
ZiPstill uses two and resolves to application/zip; exactZretains its own type.20,000 warmed lowercase misses: 0.00776s before, 0.00555s after locally. Allocations are unchanged (~40,000); this is a bounded microbenchmark, not a general throughput claim. All 2,086 rows in the reviewed main databases plus four case/miss checks pass.
Verification
Compatibility
No intended breaking changes or dependency/data/version updates. Lookup results and bounded cache semantics remain unchanged.