Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(dependencies): update all dependencies #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kristinita
Copy link

1. Summary

I updated versions of all dependencies, devDependencies and peerDependencies to the latest versions as of September 7, 2022.

2. Argumentation of changes

In my opinion, the need for updates to the 2018 versions is obvious. node-grunt-http-server at the time of this pull request was using http-server 0.11.0, while the newest http-server version — 14.1.1. Not surprisingly, users of node-grunt-http-server may have a lot of bugs.

2.1. Examples of bugs

When using node-grunt-http-server for my project, I get bugs below.

node-grunt-http-server incorrectly handle:

  1. big HTML files like this
  2. non-ASCII URLs like https://журнальныймир.рф/avtor/savchenko-boris
  3. relative links to the root index.html like <a href="..">Link to index.html in the parent folder</a>

I haven’t these bugs after dependencies updates.

Thanks.

Update all dependencies, devDependencies and peerDependencies as of 2022
@aetheon
Copy link
Contributor

aetheon commented Sep 8, 2022

Hi @Kristinita are you still using this module? or was this just a random contribution to bump deps?

@Kristinita
Copy link
Author

Kristinita commented Sep 8, 2022

Hi @Kristinita are you still using this module?

Type: Reply 💬

@aetheon, yes, I still use node-grunt-http-server. Due to outdated dependencies, I have some bugs — see item 2.1 of my comment. But after dependencies updates, I have no problem using node-grunt-http-server for my project.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants