fix(feed): retry web playback after age verification#4702
Open
rabble wants to merge 3 commits into
Open
Conversation
🔗 Link this PR to an issueThis PR doesn't reference a tracking issue yet. These open issues look related:
To link: edit the PR description and add This comment and the |
This comment has been minimized.
This comment has been minimized.
Web auth-gated fullscreen videos were left on the age-restricted overlay after verification because the HLS player was never recreated. Retry the active web player once auth succeeds so playback can load with fresh viewer headers. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Age verification returns request headers that must be used when recreating the web player; otherwise the retry immediately hits the age gate again. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rabble
force-pushed
the
fix/web-age-gate-retry
branch
from
6f0b5a5 to
4a08544
Compare
This comment has been minimized.
This comment has been minimized.
Age-gated media on web needs the HLS auth player path because direct browser MP4 playback cannot attach NIP-98 authorization headers. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Mobile PR PreviewPreview refreshed for Last refresh:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebVideoFeedState.retryPlaybackand keep fullscreen web factory injection testable.Test plan
dart format lib test integration_testNo errorsflutter test test/widgets/web_video_feed_test.dart test/screens/feed/pooled_fullscreen_video_feed_screen_test.dart(+48 ~4, 4 skipped; all other tests passed)🤖 Generated with Claude Code