Skip to content

fix: Filer property popup did note close #1578

Open
fsbraun wants to merge 2 commits intomasterfrom
fix/file-widget
Open

fix: Filer property popup did note close #1578
fsbraun wants to merge 2 commits intomasterfrom
fix/file-widget

Conversation

@fsbraun
Copy link
Member

@fsbraun fsbraun commented Feb 18, 2026

Description

Fix filer admin dropzone/file widget behaviour to properly reset state and avoid popup/autocomplete conflicts, improve layout, and refine selection/action UI.

Bug Fixes:

  • Remove incompatible autocomplete context attribute from filer file widget to prevent Django popup JavaScript issues.
  • Ensure Dropzone preview template is correctly loaded and clear buttons are triggered on drop to close/clear filer property popups.
  • Correct selection counter default handling in the folder directory list template to avoid string defaults.
  • Fix documentation string typo in permission admin autocomplete configuration.

Enhancements:

  • Increase drag-and-drop widget minimum width and adjust admin CSS and JavaScript to improve dropzone appearance, responsiveness, and hover states.
  • Refine list and bulk-action UI behaviour in the navigator, including action enabling, selection toggles, and breadcrumb/search interactions.
  • Bundle and update filer-base and admin-file-widget JavaScript assets to reflect the new Dropzone and UI logic.

This PR fixes #1577, though the underlying issue is not fully understood.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.98%. Comparing base (6ea5d6d) to head (dc81c69).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1578   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files          78       78           
  Lines        3671     3672    +1     
  Branches      498      498           
=======================================
+ Hits         2826     2827    +1     
  Misses        675      675           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fsbraun, your pull request is larger than the review limit of 150000 diff characters

@fsbraun fsbraun requested a review from vinitkumar February 18, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filer Popup not closing if opened from CMS-Plugin config modal.

1 participant