Skip to content

Add support for customized tailwind cli asset name #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Tobi-De
Copy link
Contributor

@Tobi-De Tobi-De commented Sep 5, 2024

The code changes introduce a new setting, TAILWIND_CLI_ASSET_NAME. The last release introduced TAILWIND_CLI_SRC_REPO, but that alone is not enough to pull from a customized repository. The repository might be using a custom name for the Tailwind CLI file, such as tailwind-extra. This case was not taken into account, an oversight on my part.

The code changes introduce a new setting, `TAILWIND_CLI_ASSET_NAME`. The last release introduced `TAILWIND_CLI_SRC_REPO`, but that alone is not enough to pull from a customized repository. The repository might be using a custom name for the Tailwind CLI file, such as `tailwind-extra`. This case was not taken into account, an oversight on my part.
@Tobi-De Tobi-De changed the title feat: Add support for customized tailwind cli asset name Add support for customized tailwind cli asset name Sep 5, 2024
@Tobi-De
Copy link
Contributor Author

Tobi-De commented Sep 5, 2024

Sorry again 😅
This time I was able to run the full test suite locally, tests passed.
I was also of thinking of adding specific tests for this feature, but frankly I'm not sure what or how to test it

@oliverandrich oliverandrich merged commit f713f22 into django-commons:main Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants