Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 24, 2025

@amirreza8002
Copy link
Member

amirreza8002 commented Sep 24, 2025

Hi!

thank you! looks good to me

@amirreza8002
Copy link
Member

hi
please reset this last commit
we keep a linear history, so a rebase is the way to handle it
tho if it's a problem, i can do it myself 👍

@cclauss
Copy link
Contributor Author

cclauss commented Sep 25, 2025

I have rebased to a single commit, but this pull request is in draft mode because it has failing tests caused by:

@amirreza8002
Copy link
Member

yup
thank you 🙌
I'll merge as soon as they fix their end

@cclauss
Copy link
Contributor Author

cclauss commented Sep 25, 2025

The GitHub UI provides Squash and merge to make it easy to keep history linear.

Squash and Merge

@amirreza8002
Copy link
Member

yup
but usually i want all commits to be available, so squashing is not my go to option, rebase is the way

@cclauss cclauss force-pushed the patch-1 branch 3 times, most recently from d39f7a4 to 38437df Compare October 5, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants