RE: Add HTTP Trailers #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do like this in general, but I feel like we need a |
|
This can be closed. It was already merged on #339. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a PR open regarding this. I wanted to open this to add options to the discussion. I did the uvicorn implementation.
As stated in the other proposal PR this works a bit differently. This adds a new message type
http.response.trailersand a newtrailersbool property tohttp.response.start. IMO this simplifies the implementation.My original POC did not account for chunked trailers but this would be easy to add with a
more_trailersproperty similar to themore_bodyproperty.Personally I like the
more_bodybeing set to false when the body is done and trailers being sent after. It makes more sense to me, but at the end of the day if any trailers get added I will be happy.