Fix: Business display order in board minutes (#1868) #1982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes focus indicators for links and CTAs * Fixes padding on the navigation items * Adds focus indicators for buttons same as links Refs django#1381
updates: - [github.com/pycqa/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0)
This is a test run. If the volume of PRs gets too high it will be disabled again.
Fixes django#1467 and django#990 --------- Co-authored-by: Baptiste Mispelon <[email protected]>
Bumps [django-contact-form](https://github.com/ubernostrum/django-contact-form) from 2.1 to 5.0.1. - [Changelog](https://github.com/ubernostrum/django-contact-form/blob/trunk/docs/changelog.rst) - [Commits](ubernostrum/django-contact-form@2.1...5.0.1) --- updated-dependencies: - dependency-name: django-contact-form dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [django-read-only](https://github.com/adamchainz/django-read-only) from 1.12.0 to 1.16.0. - [Changelog](https://github.com/adamchainz/django-read-only/blob/main/CHANGELOG.rst) - [Commits](adamchainz/django-read-only@1.12.0...1.16.0) --- updated-dependencies: - dependency-name: django-read-only dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [tox](https://github.com/tox-dev/tox) to permit the latest version. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst) - [Commits](tox-dev/tox@0.5...4.15.1) --- updated-dependencies: - dependency-name: tox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [redis](https://github.com/redis/redis-py) from 3.5.3 to 5.0.7. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@3.5.3...v5.0.7) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [psycopg2](https://github.com/psycopg/psycopg2) from 2.9.3 to 2.9.9. - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS) - [Commits](https://github.com/psycopg/psycopg2/commits/2.9.9) --- updated-dependencies: - dependency-name: psycopg2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [django-countries](https://github.com/SmileyChris/django-countries) from 7.5.1 to 7.6.1. - [Changelog](https://github.com/SmileyChris/django-countries/blob/main/CHANGES.rst) - [Commits](SmileyChris/django-countries@v7.5.1...v7.6.1) --- updated-dependencies: - dependency-name: django-countries dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
The stripe API rejects anything > $999,999.99 and we're sporadically getting error reports on Sentry from people trying out 1 million.
Bumps [requests-mock](https://github.com/jamielennox/requests-mock) from 1.9.3 to 1.12.1. - [Release notes](https://github.com/jamielennox/requests-mock/releases) - [Commits](jamielennox/requests-mock@1.9.3...1.12.1) --- updated-dependencies: - dependency-name: requests-mock dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.3.0 to 10.4.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@10.3.0...10.4.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pylibmc](https://github.com/lericson/pylibmc) from 1.6.1 to 1.6.3. - [Release notes](https://github.com/lericson/pylibmc/releases) - [Changelog](https://github.com/lericson/pylibmc/blob/master/docs/changelog.rst) - [Commits](lericson/pylibmc@1.6.1...1.6.3) --- updated-dependencies: - dependency-name: pylibmc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
updates: - [github.com/adamchainz/django-upgrade: 1.18.0 → 1.19.0](adamchainz/django-upgrade@1.18.0...1.19.0)
This change causes no visual difference on the site since this font weight is not being requested for Roboto from Google Fonts, but it technically reduces the amount of font variants the site needs. The 600 value was added in 5d8bd41.
Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.6.11 to 7.6.12. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.6.11...7.6.12) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.20.0 to 2.21.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.20.0...2.21.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
updates: - [github.com/rbubley/mirrors-prettier: v3.5.0 → v3.5.1](rbubley/mirrors-prettier@v3.5.0...v3.5.1) - [github.com/pycqa/flake8: 7.1.1 → 7.1.2](PyCQA/flake8@7.1.1...7.1.2)
updates: - [github.com/rbubley/mirrors-prettier: v3.5.1 → v3.5.2](rbubley/mirrors-prettier@v3.5.1...v3.5.2)
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 2.21.0 to 2.22.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.21.0...2.22.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [psycopg[c]](https://github.com/psycopg/psycopg) from 3.2.4 to 3.2.5. - [Changelog](https://github.com/psycopg/psycopg/blob/master/docs/news.rst) - [Commits](psycopg/psycopg@3.2.4...3.2.5) --- updated-dependencies: - dependency-name: psycopg[c] dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
This change ends the project's reliance on Google Fonts as a remote font asset host. Roboto is released under the SIL Open Font License, Version 1.1: https://github.com/googlefonts/roboto-3-classic/?tab=OFL-1.1-1-ov-file The initial TTF font files were downloaded from GitHub: https://github.com/googlefonts/roboto-3-classic/releases/tag/v3.010 Then I ran `ftcli converter ft2wf --flavor woff2` on the files from the `web` directory to generate `woff2` files: https://ftcli.github.io/FoundryTools-CLI/commands/ftcli_converter.html
- Stopped using jQuery - Split concerns and add precondition checks to reduce nesting - Add `preventScroll: true` option to `focus` call - Stop passing default `block` option to `scrollIntoView` call - Moved refactored code to `djangoproject.js`
Bumps [isort](https://github.com/PyCQA/isort) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/PyCQA/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@6.0.0...6.0.1) --- updated-dependencies: - dependency-name: isort dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
updates: - [github.com/rbubley/mirrors-prettier: v3.5.2 → v3.5.3](rbubley/mirrors-prettier@v3.5.2...v3.5.3) - [github.com/pycqa/isort: 6.0.0 → 6.0.1](PyCQA/isort@6.0.0...6.0.1) - [github.com/tox-dev/pyproject-fmt: v2.5.0 → v2.5.1](tox-dev/pyproject-fmt@v2.5.0...v2.5.1)
Thank you Baptiste Mispelon for the review.
- Stopped using jQuery - Moved refactored code to `djangoproject.js`
Added the '/' key as a secondary shortcut to focus the search input, for consistency with forum.djangoproject.com, github.com, docs.python.org, and most ReadTheDocs sites. (Ctrl+K and Command-K are also still supported.) Fixes django#1946.
Changed display of the search shortcut key to "⌘ K" on Mac and "Ctrl+K" elsewhere. (\u200a is a hair space, which looks better than a full space or no space.) Fixes django#1960.
Also added an --interactive flag to prompt before building each version, making it possible to skip some.
This reverts commit fa56d9b.
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.5 to 3.1.6. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.5...3.1.6) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [django](https://github.com/django/django) from 5.1.5 to 5.1.7. - [Commits](django/django@5.1.5...5.1.7) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
PAMIDIVENKATAMANASA
force-pushed
the
fix-business-display-order
branch
from
00e5dcf to
2451810
Compare
|
This PR fixes issue #1868. Could you please review and approve the workflows when you get a chance? Thank you!" |
bmispelon
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Hi and thanks for your PR!
You should be including the generated migration in your PR, and there should also be a data migration to populate the field otherwise the sorting will be wrong.
I would also put the ordering by -created_at as default for the model in Business.Meta (that way you don't have to create a custom ModelAdmin for it.
Thanks!
PAMIDIVENKATAMANASA
force-pushed
the
fix-business-display-order
branch
from
2451810 to
49c02ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that new business items in board minutes are displayed in the order they were added in the Django admin, instead of alphabetical order.