Stable/1.4.x #12
Open
Stable/1.4.x #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ested development service to Bonsai.
We recently updated to jQuery 2.x and this requires quotes around attribute values. Fixes #2380 Fixes #2381
…ommended solution.
Fixes #2369 The static() function was being called during app load which caused a crash when the user is using STATICFILES_STORAGE=ManifestStaticFilesStorage, DEBUG=False and haven't yet collected static files. I've moved it into a property and it's now only called when a view is being rendered. This also is more consistent because we usually set media using properties (and so does Django admin).
Unless overridden by passing `base_form_class=CustomFormClass` to an EditHandler, the EditHandler now gets the base form class from the model. People who override the EditHandler of a model no longer have to also override the base_form_class if the model needs a custom one. Fixes #2267
Forms for Page classes must subclass WagtailAdminPageForm. If they do not, an error will be thrown for invalid arguments when the Page editor is opened. Partial fix for #2267.
Some code was using methods from Wagtail, even though those methods were deprecated with alternatives provided. Those alternatives are now used instead.
Using ContentTypes can lead to the awkward case where they are used before the database is migrated, leading to errors on start up. Removing ContentTypes and using plain Model classes instead makes this impossible, and also makes the code clearer. Fixes #2433
If the developer had overridden MESSAGE_TAGS in their site, Wagtail messages used these classes in the admin. This caused the messages to lose their styles. Wagtail now ignores the MESSAGE_TAGS setting, using the default classes defined in `django.contrib.messages.constants.LEVEL_TAGS`. Fixes #2551 Conflicts: wagtail/tests/testapp/urls.py wagtail/wagtailadmin/templatetags/wagtailadmin_tags.py
…h 2.0... I think)
…s unless --elasticsearch specified Conflicts: runtests.py
…ith_page_permissions_shown
Fixes #2519. Fix provided by @alexgleason
…rget.activeElement
IE doesn't provide standard onload event listeners on opened windows, so this code did user-agent sniffing on the string 'MSIE' to bypass the onload animation. This failed on IE11, which drops 'MSIE' from the user agent string. The code now checks for the presence of addEventListener instead. As a bonus, it now falls back on IE's (non-standard?) attachEvent method, so the animation now works on IE after all.
…ate - fixes #2599
…cleared. This also fixes #2608, which is caused by IE's buggy 'oninput' event handling - it treats the clearing of the placeholder text when the search box is focused as a user input action, and thus immediately fires off an empty search query. This change means that the empty search has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:
make lintfrom the Wagtail root)