Skip to content

Conversation

@djangodeveloper96
Copy link
Owner

Thanks for contributing to Wagtail! 🎉

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

  • Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
  • Does the code comply with the style guide? (Run make lint from the Wagtail root)
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?
    • Please list the exact browser and operating system versions you tested.
    • Please list which assistive technologies you tested.
  • For new features: Has the documentation been updated accordingly?

gasman and others added 30 commits October 6, 2017 16:22
…resql backend doesn't support it

Fixes #3899 - thanks @sivictorallen for the report!
Also remove tr_TR translations, as they will mask the more-complete TR translation due to #3600.
Fixes #3967

If there was no site configured, the listing views in the API would
break with an AttributeError.

Now, the following happens if there is no site record:
 - In the Admin API, all pages are returned but links in the response do
not include a domain name
 - In the Public API, no pages are returned
When all pages on a site is private, the last_mods set will be empty
causing a crash when trying to get the max value from it.
This fix adds a test that the set is truthy (not empty) before calling
max.
It appears that the bug may have reappeared in 5.5 final. Fixes #3985
…n filtering by __in with a subquery

This ensures that it will work equivalently for lists (as returned when connection.features.can_use_chunked_reads is False) as for iterators, and means we don't need to worry about missing results if we ever receive a chunked resultset.
…avis test matrix

We now know that sqlite vs postgresql is a meaningfully different code path for our ES5 tests, so they warrant separate test runs more than py3.5 versus py3.6 does...
…boost values

It's valid for the same field to exist as both a SearchField and FilterField, and in this case get_boost would randomly find the FilterField and try (and fail) to read its 'boost' attribute.
gasman and others added 30 commits November 17, 2017 11:13
…s in their representation

Calling `repr()` on a model instance that has non-ASCII characters in
its string representation returns a UTF8-encoded bytestring that
includes that representation. This cannot be substituted into a
`unicode` string, since Python will attempt and fail to decode it with
the `ascii` codec.
Conflicts:
	CHANGELOG.txt
	docs/releases/index.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants