Skip to content

Conversation

@djangodeveloper96
Copy link
Owner

Thanks for contributing to Wagtail! 🎉

Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:

  • Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
  • Does the code comply with the style guide? (Run make lint from the Wagtail root)
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?
    • Please list the exact browser and operating system versions you tested.
    • Please list which assistive technologies you tested.
  • For new features: Has the documentation been updated accordingly?

gasman and others added 30 commits April 21, 2020 15:37
…g Pages to Snippets". If this is not included sorting in InlinePanel won't work so good to include it in documentation.
Fixes #6174

Conflicts:
	wagtail/contrib/sitemaps/tests.py
…n INSTALLED_APPS

The sitemap_generator module is imported from wagtail/contrib/sitemaps/__init__.py, which causes it to be imported immediately if wagtail.contrib.sitemaps is in INSTALLED_APPS (which is not required or part of the setup docs, but is something people are understandably likely to do). This is too early in startup to import models, and fails with an AppRegistryNotReady exception.

There's probably a good case for not having that import in __init__.py, but some code/docs in the wild relies on it (e.g. https://stackoverflow.com/questions/44681046/how-to-join-wagtail-and-django-sitemaps), so better to leave it in for now.
This can be disabled with the setting WAGTAILFORMS_HELP_TEXT_ALLOW_HTML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants