Stable/1.8.x #18
Open
Stable/1.8.x #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid(0)" instead - fixes #3208 The stopPropagation() call was too eager, as this blocked legitimate clicks on the links in the 'more' dropdown. Yes, I know javascript:void(0) is evil, but it's less evil than href="#" in that it doesn't have side effects. And if the design calls for an element that has the same styling and interactions as an `<a>` element but just happens to trigger an in-page action rather than navigating to a new URL, I don't see why I should jump through hoops undoing the native style of an alternative element like `<button>` to achieve something that's perfectly simple to do the 'evil' way, and as far as I'm aware has no negative effects other than to cause HTML purists to roll their eyes. SO THERE.
`page.get_children` was changed earlier to `blogpages` in order to show the blog posts ordered and hide the unpublished ones
Gulp 3.x is currently incompatible with Node 7: gulpjs/gulp#1843 Fixes #3253
…pear at the end of urlpatterns
…he Google group (#3255) We plan to put additional resources into support on Stack Overflow, based on feedback at https://twitter.com/WagtailCMS/status/801384753589080064
Thanks to @gogobook for the report!
…ially different This prevents the migration engine from optimising them away - see wagtail/wagtail#3293 (comment)
…ggered by post_save signals test_removes_object wrongly asserted that the 'add' method (not 'delete') was called; this should have failed, but didn't, because the mock was picking up the 'add' call that happened during object creation as a result of the post_save signal. Here we insert calls to .reset_mock() to stop the signals from interfering with the tests, and fix the broken assertion that was masked by this bug.
…rom save(update_fields=[...]). Fixes #3239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines https://docs.wagtail.io/en/latest/contributing/index.html and check the following:
make lintfrom the Wagtail root)